Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staticman now supports GitLab! #1949

Closed
VincentTam opened this issue Nov 18, 2018 · 1 comment · Fixed by #1956
Closed

Staticman now supports GitLab! #1949

VincentTam opened this issue Nov 18, 2018 · 1 comment · Fixed by #1956

Comments

@VincentTam
Copy link
Contributor

Motivation

In docs/_docs/05-configuration.md, it's written that

Note: Staticman is currently only compatible with GitHub based repositories. Support for GitLab Pages is planned but not available yet.

This is outdated. eduardoboucas/staticman#219 (comment) announced the launching of a public API instance https://dev.staticman.net two months ago.

Thanks to @ntsim's help, I've understood how to use his PR. As a result, I've created my 2nd demo Staticman GitLab Pages at https://vincenttam.gitlab.io/bhdemo (source, served by @staticmanlab) yesterday (in order to demonstrate my recent PR to the Hugo theme halogenica/beautifulhugo#222).

Staticman v3 on GitLab

Coincidently, Staticman's main API is facing eduardoboucas/staticman#227. This is also discussed in #1842. The result of #1842 is to allow users to customize their own API instance. In fact, on GitLab, such problem doesn't exist because the "accept invitation" mechanism doesn't exist---another user can immediately start contributing once invited. Therefore, eduardoboucas/staticman#219 can, unexpectedly, solve #1842, apart from eduardoboucas/staticman#22.

From my GitLab repo setup guide, one can setup Staticman to work with GitLab.

Suggestion

Please update this notice to

Note: Staticman is currently compatible with GitHub and GitLab based repositories. Support for GitLab Pages is already available.
@mmistakes
Copy link
Owner

mmistakes commented Nov 18, 2018 •
edited
Loading

Care to submit a PR changing the documentation text?

@VincentTam VincentTam mentioned this issue Nov 19, 2018
Merged
@VincentTam VincentTam mentioned this issue Dec 25, 2018
Closed
okitem pushed a commit to okmalls/okmalls.github.io that referenced this issue Oct 5, 2024
@denis-games @denisj
fix(i18n): correct fr-FR translations (mmistakes#1949)
367262e 
Co-authored-by: Denis Jean <dj@denisjean.fr>
okitem pushed a commit to okmalls/okmalls.github.io that referenced this issue Oct 5, 2024
@semantic-release-bot
chore(release): 7.1.1
fd0df83 
## [7.1.1](cotes2020/jekyll-theme-chirpy@v7.1.0...v7.1.1) (2024-09-23)

### Bug Fixes

* **i18n:** correct fr-FR translations ([mmistakes#1949](cotes2020/jekyll-theme-chirpy#1949)) ([367262e](cotes2020/jekyll-theme-chirpy@367262e))
* **pwa:** site baseurl not passed to `app.js` ([mmistakes#1955](cotes2020/jekyll-theme-chirpy#1955)) ([5a63244](cotes2020/jekyll-theme-chirpy@5a63244))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update 05-configuration.md VincentTam/minimal-mistakes
2 participants
@mmistakes @VincentTam