Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal bug somewhere between 3.22.1 + 3.23.0 #28

Open
mixmix opened this issue Aug 5, 2019 · 6 comments
Open

fatal bug somewhere between 3.22.1 + 3.23.0 #28

mixmix opened this issue Aug 5, 2019 · 6 comments

Comments

@mixmix
Copy link
Collaborator

mixmix commented Aug 5, 2019

What it looks like : with 3.23.0 if you open a gathering editing form in Patchbay you get an empty form. If you do the same with 3.22.1 the form shows the gathering's current values.

I can confirm that the data is being fetched, and even successfully set in a Struct, but the h is just not noticing that change.

In trying to figure out this bug I've seen the same problem with computed - a value the computed should be watching is definitely being updated, but a debug inside the computed is never hit.

forces me to lock at earlier version

@mixmix
Copy link
Collaborator Author

mixmix commented Aug 5, 2019

Only things I can think which might be odd / relevant

  • this bug doesn't happen with npm linked patchbay-gatherings module, it only presents itself once you've published and installed the module
    • means you have to test things by editing your node_modules installed version directly!
  • I'm doing some of this code around a modal which I'm hiding/ showing
    • experience same problem when using css : visibility or display styles
  • I'm watching some of the observeables like this :
    var isOpen = Value(false)
    
    // somewhere else:
    isOpen(state => {
      // do stuff
    })

mixmix added a commit to ssbc/patchbay that referenced this issue Aug 5, 2019
@mixmix
Copy link
Collaborator Author

mixmix commented Aug 5, 2019

time spent so far ~4 hours
(just as a reference so you know I'm not just posting without trying a bunch)

mixmix added a commit to ssbc/patchbay that referenced this issue Aug 5, 2019
@mixmix
Copy link
Collaborator Author

mixmix commented Aug 5, 2019

cc @christianbundy (in case you bump into any mystery behaviour!) .... oh wait Patchwork is using a branch of mutant ... I wonder if it branches off before / after this bug!

@christianbundy
Copy link

Thank you!

@mmckegg
Copy link
Owner

mmckegg commented Aug 6, 2019

@mixmix do you want to pair on this on Thursday? I have an office hour available at 10am.

@mixmix
Copy link
Collaborator Author

mixmix commented Aug 6, 2019

OFFICE HOUR, don't mind if I do!
Yeah I'd love to @mmckegg , I'll put it in my calendar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants