Bugfix on expanding last row of a grouped view #937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you have a grouped view, and expanding the last one there are 2 problems: 1) The last row expander style is not changed 2) Expanding another row, will duplicate the last one
|
Thanks so much for fixing this. I hope it gets rolled into the master branch soon. |
|
It may be fixed by Pull #898 also. It is not merged to master branch, but I already merged to my fork. |
|
An equivalent patch has been integrated into my 'alternative master'. Any testing is appreciated. See #1055 |
jesenko
pushed a commit
to plandela/SlickGrid
that referenced
this pull request
Dec 29, 2023
…man#937 (mleibman#938) * fix: only allow row drag on cell w/`dnd` or `cell-reorder`, fix mleibman#937 - a previous PR mleibman#897 caused a regression on a cell with a select dropdown (like `Slick.Editors.YesNoSelect`), the regression was caused by the implementation of Draggable `allowDragFromClosest` which will check if current DOM element is `.slick-cell` or if not it will also try its ancestor and that caused the regression because the cell with the editor also had a `.slick-cell` and so the code taught that the user started a drag and it cancelled event bubbling which in turn also prevented the select dropdown to be clickable. - to fix this issue we need to make sure that the cell is queried not just with `div.slick-cell` but also with certain CSS classes, we need to check if parent has either `.dnd` or `.cell-reorder` to permit the dragging when checking parent cell with `allowDragFromClosest`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a grouped view, and expanding the last one there are 2 problems: