Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand group bug #953

Open
mkkim417 opened this issue Jun 9, 2014 · 3 comments
Open

Expand group bug #953

mkkim417 opened this issue Jun 9, 2014 · 3 comments

Comments

@mkkim417
Copy link

mkkim417 commented Jun 9, 2014

http://mleibman.github.io/SlickGrid/examples/example-grouping

First, click 'Group by duration & sort groups by value ' button
and then, click 'Collapse all groups'

and Try to expand last second group.

last group title rows doesn't disappeared.

@danjger
Copy link

danjger commented Oct 28, 2014

I see this issue and here is an easy way to reproduce.
visit: http://mleibman.github.io/SlickGrid/examples/example-grouping
Click 50k rows
Click Collapse all groups
Expand Top section (Duration 0) and scroll down to see a spurious header for another grouping

They appear in just about every group but a little father down when you have enough entries in a single group.

@danjger
Copy link

danjger commented Oct 29, 2014

ok I saw another but report just like this one: #841
I deployed the users suggested fix and it seems to take care of the issue:
icoxfog417#3

diff --git a/slick.groupitemmetadataprovider.js b/slick.groupitemmetadataprovider.js
index c40551c..55d40bc 100644
--- a/slick.groupitemmetadataprovider.js
+++ b/slickgrid/slick.groupitemmetadataprovider.js
@@ -82,7 +82,7 @@
         var range = _grid.getRenderedRange();
         dataView.setRefreshHints({
           ignoreDiffsBefore: range.top,
-          ignoreDiffsAfter: range.bottom
+          ignoreDiffsAfter: range.bottom + 1
         });

         if (item.collapsed) {
@@ -106,7 +106,7 @@
             var range = _grid.getRenderedRange();
             dataView.setRefreshHints({
               ignoreDiffsBefore: range.top,
-              ignoreDiffsAfter: range.bottom
+              ignoreDiffsAfter: range.bottom + 1
             });

@6pac
Copy link

6pac commented Mar 13, 2015

This has been integrated into my 'alternative master'. Any testing is appreciated. See #1055

jesenko pushed a commit to plandela/SlickGrid that referenced this issue Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants