Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pytorch objects inference fix #422

Merged

Conversation

psfoley
Copy link
Contributor

@psfoley psfoley commented May 3, 2022

Credit to @sarthakpati for the base implementation!

Proposed Changes

  • Correctly populates header information for inference when only validation CSV is provided to create_pytorch_objects function
  • Handles a couple other corner cases where training header information is needed
  • Used in conjunction with FeTS Challenge 2022

Checklist

  • [ x ] I have read the CONTRIBUTING guide
  • [ x ] My PR is based from the current GaNDLF master
  • [ x ] Non-breaking change (would not break existing functionality): please provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@psfoley psfoley changed the title Create pytorch objects inference fix WIP: Create pytorch objects inference fix May 3, 2022
@psfoley psfoley changed the title WIP: Create pytorch objects inference fix Create pytorch objects inference fix May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #422 (c471f64) into master (37886ab) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   92.35%   92.34%   -0.01%     
==========================================
  Files         104      104              
  Lines        6082     6088       +6     
==========================================
+ Hits         5617     5622       +5     
- Misses        465      466       +1     
Flag Coverage Δ
unittests 92.34% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/compute/generic.py 94.11% <81.81%> (-2.44%) ⬇️
GANDLF/compute/forward_pass.py 91.89% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37886ab...c471f64. Read the comment docs.

@sarthakpati sarthakpati self-requested a review May 3, 2022 15:26
sarthakpati
sarthakpati previously approved these changes May 3, 2022
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Not merging directly since some of my code was in the merge structure. Thoughts, @Geeks-Sid?

Geeks-Sid
Geeks-Sid previously approved these changes May 3, 2022
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarthakpati sarthakpati merged commit e4d0d4b into mlcommons:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants