Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define NOMINMAX before windows.h #1715

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Dec 18, 2024

Refs #1513.

Fix build failure with MSVC after #1706.

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@awni awni merged commit c8fb549 into ml-explore:main Dec 18, 2024
5 checks passed
@zcbenz zcbenz deleted the msvc-nominmax branch January 29, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants