Using math defines requires switch in MSVC (#1665)

* Using math defines requires switch in MSVC * Fix more math macros * Fix type * Remove _MSC_VER guard for math defines
ml-explore · Dec 8, 2024 · d0f471c · d0f471c
1 parent 6f316b8
commit d0f471c
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 0 deletions.
diff --git a/mlx/ops.cpp b/mlx/ops.cpp
@@ -1,4 +1,8 @@
 // Copyright © 2023-2024 Apple Inc.
+
+// Required for using M_PI in MSVC.
+#define _USE_MATH_DEFINES
+
 #include <algorithm>
 #include <climits>
 #include <cmath>

diff --git a/mlx/primitives.cpp b/mlx/primitives.cpp
@@ -1,4 +1,8 @@
 // Copyright © 2023-2024 Apple Inc.
+
+// Required for using M_2_SQRTPI in MSVC.
+#define _USE_MATH_DEFINES
+
 #include <algorithm>
 #include <cassert>
 #include <cmath>

diff --git a/tests/autograd_tests.cpp b/tests/autograd_tests.cpp
@@ -1,5 +1,8 @@
 // Copyright © 2023 Apple Inc.
 
+// Required for using M_2_SQRTPI in MSVC.
+#define _USE_MATH_DEFINES
+
 #include <algorithm>
 #include <cmath>
 #include <numeric>

diff --git a/tests/compile_tests.cpp b/tests/compile_tests.cpp
@@ -1,5 +1,8 @@
 // Copyright © 2023-2024 Apple Inc.
 
+// Required for using M_SQRT2 in MSVC.
+#define _USE_MATH_DEFINES
+
 #include "doctest/doctest.h"
 
 #include "mlx/mlx.h"

diff --git a/tests/ops_tests.cpp b/tests/ops_tests.cpp
@@ -1,4 +1,8 @@
 // Copyright © 2023-2024 Apple Inc.
+
+// Required for using M_PI_2 in MSVC.
+#define _USE_MATH_DEFINES
+
 #include <cmath>
 #include <numeric>