Add integration tests (via Travis CI) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Turns out that Travis CI's Ubuntu 12.04 doesn't support the `ln -r` flag.)
|
(Oh, the PR also ended up pulling in the |
|
I've now submitted a separate PR (with clean history) for the bug that caused the Ansible 2.2 failures. See here: #9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you're interested, but I put together some test coverage for these modules via Travis CI to help me triage a bug with the modules that I was investigating (they don't work with Ansible >=2.2).
You can view the test results in Travis CI here: https://travis-ci.org/karlmdavis/ansible-role-ldap. Note that they're failing right now when run against Ansible 2.2, which is expected. They pass when run against Ansible 2.1, though, which is also expected.
Here's a PR with that test coverage, if you'd like to take it. I'd be happy to rework it a bit, if you have questions or concerns. I'd also be happy to just maintain them on my fork, if you're not interested.
Happy New Years!
Karl M. Davis