Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow request mappings to handle a request based on host #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jwgmeligmeyling
Copy link

Fixes #121

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.58%. Comparing base (f6311c9) to head (7c4993c).
Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
...ron/configuration/RequestMappingConfiguration.java 50.00% 2 Missing ⚠️
...charon/configuration/RequestMappingConfigurer.java 0.00% 2 Missing ⚠️
...ylec/charon/forwarding/RequestMappingResolver.java 75.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
- Coverage     90.80%   90.58%   -0.23%     
- Complexity      542      544       +2     
============================================
  Files           167      167              
  Lines          1849     1858       +9     
  Branches         54       55       +1     
============================================
+ Hits           1679     1683       +4     
- Misses          148      152       +4     
- Partials         22       23       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@mkopylec mkopylec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing must be done for webflux module

Copy link
Owner

@mkopylec mkopylec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests for this feature must be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to map by host pattern instead of just path
4 participants