Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add activesupport 8.0 support #96

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

bilby91
Copy link
Contributor

@bilby91 bilby91 commented Nov 9, 2024

No description provided.

@bilby91 bilby91 force-pushed the feat/add-active-support-8-support branch from 9030502 to 8dee55e Compare November 9, 2024 16:16
@bilby91
Copy link
Contributor Author

bilby91 commented Nov 9, 2024

@mkon Not sure what you think about the change to the GitHub action, activesupport 8 doesn't support ruby 3.1. Happy to change the implementation.

@mkon
Copy link
Owner

mkon commented Nov 11, 2024

Hey @bilby91, thanks for the PR 👍.
I think we should just drop support for ruby 3.1 since it is quite easy to upgrade ruby. This should keep the test matrix simple.

@bilby91
Copy link
Contributor Author

bilby91 commented Nov 11, 2024

@mkon Make sense. I wasn't sure if you wanted to remove it because is technically still supported. I think the tradeoff makes sense :).

Waiting for jobs to complete and should be ready for merging.

@mkon
Copy link
Owner

mkon commented Nov 12, 2024

@bilby91 can you raise the required_ruby_version to 3.2+ in the gemspec?

@bilby91 bilby91 force-pushed the feat/add-active-support-8-support branch from 609f763 to 0aecd88 Compare November 12, 2024 15:22
@bilby91
Copy link
Contributor Author

bilby91 commented Nov 12, 2024

@mkon Done!

@bilby91 bilby91 force-pushed the feat/add-active-support-8-support branch from 0aecd88 to 3a8aa10 Compare November 12, 2024 15:25
Copy link
Owner

@mkon mkon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks :)

@mkon mkon merged commit 0df936d into mkon:main Nov 13, 2024
42 checks passed
@bilby91
Copy link
Contributor Author

bilby91 commented Nov 27, 2024

@mkon Can you release a new version ?

@bilby91 bilby91 deleted the feat/add-active-support-8-support branch November 27, 2024 12:56
@mkon
Copy link
Owner

mkon commented Nov 29, 2024

I released 0.15.1 @bilby91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants