Upgrade rubocop-rspec to version 2.19.0

[depfu]

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.18.1 → 2.19.0) · Repo · Changelog

Release Notes

2.19.0

• Add new RSpec/PendingBlockInsideExample cop. (@ydah)
• Add new RSpec/RedundantAround cop. (@r7kamura)
• Add new RSpec/Rails/TravelAround cop. (@r7kamura)
• Add new RSpec/ContainExactly and RSpec/MatchArray cops. (@faucct)
• Rename RSpec/PendingBlockInsideExample cop to RSpec/SkipBlockInsideExample. (@pirj)
• Fix a false positive for RSpec/ContextWording when context is interpolated string literal or execute string. (@ydah)
• Fix a false positive for RSpec/DescribeMethod when multi-line describe without # and . at the beginning. (@ydah, @pirj)
• Fix a false positive for RSpec/VariableName when inside non-spec code. (@ydah)
• Fix a false positive for RSpec/VariableDefinition when inside non-spec code. (@ydah)
• Fix a false positive for RSpec/PendingWithoutReason when not inside example and pending/skip with block. (@ydah, @pirj)
• Fix a false positive for RSpec/PendingWithoutReason when skip is passed a block inside example. (@ydah, @pirj)
• Fix an incorrect autocorrect for RSpec/VerifiedDoubleReference when namespaced class. (@ydah)
• Deprecate send_pattern/block_pattern/numblock_pattern helpers in favour of using node pattern explicitly. (@pirj, @ydah)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 56 commits:

• Merge pull request #1590 from rubocop/release
• Bump version to v2.19.0
• Merge pull request #1575 from ydah/refactor-skipped-or-pending
• Merge pull request #1589 from ydah/ydah/fix-1588
• Refactor and adding a common matcher in SkipOrPending module
• Fix an incorrect autocorrect for `RSpec/VerifiedDoubleReference` when namespaced class
• Merge pull request #1586 from r7kamura/feature/internal-affairs
• Auto-correct `InternalAffairs/LocationExpression` offenses
• Merge pull request #1585 from ydah/fix-ProcessedSourceBufferName
• Correct `InternalAffairs/ProcessedSourceBufferName` cop
• Merge pull request #1581 from rubocop/sunset-_pattern-helpers
• Add deprecation warning and a changelog entry
• Prepare _pattern abstraction for retirement
• Merge pull request #1580 from ydah/ci_against_jruby_9_4
• Merge pull request #1556 from ydah/extract_location
• Change to ignore `example?`, `hook?`, `let?`, `include?` and `subject?` matchers with `RSpec` receivers
• CI against JRuby 9.4 instead of JRuby 9.3
• Merge pull request #1579 from ydah/enable-some-new-cops
• Enable Style/RedundantStringEscape
• Enable Style/RedundantHeredocDelimiterQuotes and fix offenses
• Extract Location module as mixin
• Merge pull request #1577 from ydah/not-use-comment_line
• Use `line_with_comment?` instead of bad API
• Merge pull request #1573 from ydah/patch-refactor
• Add `block_or_numblock_pattern` and replace where used
• Merge pull request #1572 from rubocop/rename-pending-to-skip-block-cop
• Rename and narrow to `skip` only
• Merge pull request #1566 from ydah/fix/1565
• Fix edge cases & refactor
• Fix a false positive for `RSpec/PendingWithoutReason` when not inside example and pending/skip with block
• Merge pull request #464 from rubocop/match_array
• Add specs for non-splat case and % literal
• Rely on RESTRICT_ON_SEND
• Merge pull request #1571 from ydah/suppression-typo
• Add settings for typo suppression
• Performance optimization
• Handle percent literals as an exception
• Modernize
• Clean up code and add a changelog entry
• Implement Rubocop::Cop::RSpec::ContainExactly and Rubocop::Cop::RSpec::MatchArray
• Merge pull request #1503 from r7kamura/feature/freeze-time-around
• Add `RSpec/Rails/TravelAround` cop
• Add `RSpec/RedundantAround` cop
• Merge pull request #1569 from ydah/fix/1149
• Merge branch 'master' into fix/1149
• Merge pull request #1564 from ydah/feature/1563
• Add new `RSpec/PendingBlockInsideExample` cop
• Fix a false positive for `RSpec/VariableDefinition` when inside non-spec code
• Fix a false positive for `RSpec/VariableName` when inside non-spec code
• Merge pull request #1558 from ydah/fix-false-positive-rspec-DescribeMethod
• Merge pull request #1568 from ydah/patch-1
• Add a link to RSpec
• Explicitly show that we ignore non-string arguments
• Fix a false positive for `RSpec/DescribeMethod` when multi-line describe without `#` or `.` at the beginning
• Merge pull request #1557 from ydah/fix-false-positive-rspec-ContextWording
• Fix a false positive for `RSpec/ContextWording` when context is interpolated string literal or execute string

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)