feat: Add support for globs in paths configuration #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGuenther
commented
Aug 10, 2022
mkdocs.yml
Outdated
Comment on lines
86
to
87
| paths: | ||
| - src/* |
There was a problem hiding this comment.
I only made this change as a test to ensure things are working as expected when running make docs-serve. I can remove it, but I wanted to include it initially to show how I tested.
There was a problem hiding this comment.
Sure, you can remove it now, thanks.
This change allows for values in the paths configuration option to be globs by resolving them before passing them off to griffe. fixes mkdocstrings#33
5a41773 to
749e48c
Compare
|
These failures don't appear to be related to my change. I encountered these same failures when attempting to run tests on the main branch without my changes as well. |
|
Oh, indeed, sorry about that. Let me fix these first. |
|
@pawamoy Friendly ping to see if we can get this merged |
|
Thanks for the ping! LGTM, merging 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for values in the paths configuration option to be
globs by resolving them before passing them off to griffe.
fixes #33