Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix password string replacement #920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

whikloj
Copy link
Contributor

@whikloj whikloj commented Mar 4, 2025

Link to Github issue or other discussion

Resolved #918

What does this PR do?

Replaces the password only from the end of the string, instead of the start.

What changes were made?

How to test / verify this PR?

Run a command like

python3 scripts/make_local_tests.py --host https://jared.uri --username test_username --password somePassword

Then check one of the configuration files changed and in the tests_local directory, (i.e. tests_local/assets/check_test/delete.yml)

task: delete
host: https://jared.uri
username: test_username
somePassword: somePassword
input_csv: delete.csv
secure_ssl_only: false

Pull in this PR, re-run make_local_tests.py command and check the file again

task: delete
host: https://jared.uri
username: test_username
password: somePassword
input_csv: delete.csv
secure_ssl_only: false

Interested Parties

@mjordan


Checklist

  • Before opening this PR, have you opened an issue explaining what you want to to do?
  • Have you included some configuration and/or CSV files useful for testing this PR?
  • Have you written unit or integration tests if applicable?
  • Does the code added in this PR require a version of Python that is higher than the current minimum version?
  • If the changes in this PR require an additional Python library, have you included it in setup.py?
  • If the changes in this PR add a new configuration option, have you provided a default for when the option is not present in the .yml file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make_local_tests.py breaks the config files
1 participant