Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 39 remove gemini #42

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Issue 39 remove gemini #42

merged 3 commits into from
Apr 30, 2021

Conversation

mjordan
Copy link
Owner

@mjordan mjordan commented Apr 28, 2021

Github issue

#39

What's new

Removes direct query to Gemini to get a file's Fedora URI, and replaces that query with the 'islandora.entity_mapper' service.

How to test

This change should be invisible, it basically makes Islandora Riprap's code consistent with Islandora's. The desired results of a smoke test are that Islandora Riprap continues to work as before the changes.

  1. Install a fresh Islandora Playbook (or your preferred flavor of test enviro). Populate with some nodes and media.
  2. Install a fresh Riprap, which also contains some updates to match changes in this module. "Local" mode is OK (i.e. Riprap installed on the Drupal server, not as a remote HTTP microservice).
  3. Install this module and check out the "issue-39-remove-gemini" branch.
  4. Don't forget to add the fixity audit summaries to the Manage Media View (see "Enabling the Fixity Auditing summaries in each object's Media tab" section of this module's README).
  5. Configure the module at /admin/config/islandora_riprap/settings. Regardless of whether you're using local or remote mode, use the "Use the "sample_islandora_config.yml" configuration file (adjust as needed).

Run Ripap 4-5 times times, either via its CLI or using Drupal's cron. You should see entries in Riprap's database for them, and also fixity auditing summaries in the Manage Media View. If you do, the smoke test worked.

@ruebot
Copy link

ruebot commented Apr 30, 2021

Just tested in our production Playbook setup, and good to go!

Screenshot from 2021-04-30 12-12-27

Thank you @mjordan 🙏

@mjordan
Copy link
Owner Author

mjordan commented Apr 30, 2021

Excellent, thanks for testing!

@mjordan mjordan merged commit 206aaeb into master Apr 30, 2021
@mjordan mjordan deleted the issue-39-remove-gemini branch April 30, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants