Searchbox: Enter jumps to tracks if search query was transmitted #4844
Conversation
|
This sounds like a useful feature. I have not tested yet, but I assume that the current search is replaced by the saved search in tracks after the switch. Is this the case? What do you think about the status widget idea below the search bar, with a button that applies the same search for all tracks? |
|
Oh, looks like I need to clarify
not to "Tracks" feature. Selected feature is unchanged, this is just an alternative to 3 x Tab (> Clear button > sidebar > tracks table) |
|
Ah, I see, I have misread the PR. Just tested and it works. I don't think that this feature requires a visual feedback. However my personal main issue is the missing workflow to search in the Tracks feature after browsing the library tree. Can we merge this as it is? |
I adjusted the tooltip, so: yes! |
src/widget/wsearchlineedit.cpp
Outdated
| @@ -207,6 +208,8 @@ void WSearchLineEdit::setup(const QDomNode& node, const SkinContext& context) { | |||
| tr("Shortcuts") + ": \n" + | |||
| tr("Ctrl+F") + " " + | |||
| tr("Focus", "Give search bar input focus") + "\n" + | |||
| tr("Return") + " " + | |||
| tr("Trigger search, next press jumps to tracks view") + "\n" + | |||
There was a problem hiding this comment.
Is this still correct? In my test the search is instantly applied.
And return immediately moves to the Tracks table.
There was a problem hiding this comment.
When did that happen?
I tested with a long debounce timeout, 1500ms, and with that it worked as expected in all situations (typing query or selecting a saved query with Up/Down keys). Exception: picking a query from the history drop-down would apply that immediately.
There was a problem hiding this comment.
Ah, so it is the long debounce time that eats the first return.
How about this:
| tr("Trigger search, next press jumps to tracks view") + "\n" + | |
| tr("Triggers search before search-as-you-type timeout or jumps to results afterwards") + "\n" + |
There was a problem hiding this comment.
Oh, added it now. Thanks!
|
Please remove the draft state when done. |
Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
6911d1f to
0603fad
Compare
1st Enter press: emit query (or debounce timeout expired)
2nd Enter press: jump to tracks table
This is mainly supposed to be a shortcut for when working with the keyboard. Currently it requires 3 x Tab to get from searchbox to tracks, while it's just one press of the Browse/Trax encoder, often mapped to
[Library], GoToItem.I'm planning to add some visual feedback to signal that the query was submitted, it's not clear what that'll be though.