Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++20 #4803

Merged
merged 12 commits into from
Jun 26, 2022
Merged

C++20 #4803

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7b14f48
refactor(util): use C++11 = delete for copy&assign
Swiftb0y Jun 7, 2022
f4e7725
refactor(util): do not pass templated typename to DISALLOW_COPY_AND_A…
Swiftb0y Jun 7, 2022
3f7cfbc
fix(network::jsonwebtask): provide proper constructor
Swiftb0y Jun 14, 2022
cf766bf
fix(wtrackmenu): workaround -Wdeprecated-enum-enum-conversion
Swiftb0y Jun 14, 2022
f4abdbc
fix: "implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20"
Swiftb0y Jun 14, 2022
48824b0
fix: -Wdeprecated-enum-float-conversion
Swiftb0y Jun 14, 2022
e280b66
feat(build): switch from C++17 to C++20
Swiftb0y Jun 14, 2022
0f94d08
refactor(dlgprefcontrollers): use `auto*` for ptr variable type
Swiftb0y Jun 14, 2022
0c905ba
refactor(autodj): remove m_pPlayerManager from autodjprocessor
Swiftb0y Jun 14, 2022
1efe771
fixup! refactor(dlgprefcontrollers): use `auto*` for ptr variable type
Swiftb0y Jun 15, 2022
fdaf1b6
amend! refactor(autodj): remove m_pPlayerManager from autodjprocessor
Swiftb0y Jun 15, 2022
95d33db
fix(build): Workaround gcc bug
Swiftb0y Jun 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/benchmark/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,12 @@ else()
add_cxx_compiler_flag(-Wall)
add_cxx_compiler_flag(-Wextra)
add_cxx_compiler_flag(-Wshadow)
add_cxx_compiler_flag(-Werror RELEASE)
add_cxx_compiler_flag(-Werror RELWITHDEBINFO)
add_cxx_compiler_flag(-Werror MINSIZEREL)
# Disable -Werror because of gcc bug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to simply inline the patch here. It's only a workaround that should hopefully become obsolete in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand. So its fine as is or should I also commit a (imo redundant) patch file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how soon this will be fixed though. Neither google seems to make any effort working around this issue, nor the gcc team sees that as very urgent...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine. Hopefully, we don't need to update the lib anytime soon.

# https://github.com/google/benchmark/issues/1398
# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105329
# add_cxx_compiler_flag(-Werror RELEASE)
# add_cxx_compiler_flag(-Werror RELWITHDEBINFO)
# add_cxx_compiler_flag(-Werror MINSIZEREL)
if (NOT BENCHMARK_ENABLE_TESTING)
# Disable warning when compiling tests as gtest does not use 'override'.
add_cxx_compiler_flag(-Wsuggest-override)
Expand Down