Update controller mapping for Behringer DDM4000 mixer #4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a small update for the controller mapping of the Behringer DDM4000 mixer, adding support for QuickEffectUnit mappings.
Before this PR, the
EqualizerUnitmapping contained theenabledandsuper1controls ofQuickEffectRack1. This decision was made with the skin in mind where the QuickEffect controls are part of the EQ section. It turned out to be confusing in mappings where both EQ and QuickEffect are in use. For example, both EQ and QuickEffect have controls forenabled,super1,metaandmix. Hence I decided to create a dedicatedQuickEffectUnitin addition to the existingEqualizerUnitso that it's clear to to which section each control belongs.The changes are fully backwards-compatible. They have been tested with a custom mapping that maps a quick effect unit and deck effects (loop, reverse) to the channel sections of the mixer. I don't plan to merge this custom mapping here (because the current mapping resembles the mixer functions best), but I plan to share it on the forums when this PR is accepted. I can provide the mapping if desired.
There's intentionally no PR for the manual because the changes do not affect the documentation.