Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG.md for the 2.3.3 release #4790

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Update CHANGELOG.md for the 2.3.3 release #4790

merged 1 commit into from
Jun 12, 2022

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jun 7, 2022

I think it is time for a release.

JoergAtGithub
JoergAtGithub reviewed Jun 7, 2022
View reviewed changes
CHANGELOG.md Outdated
@@ -1,5 +1,27 @@
# Changelog

## [2.3.2](https://launchpad.net/mixxx/+milestone/2.3.3) (unreleased)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.3.3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we remove the (unreleased) here or does that the changelog updater tool for us? I forgor 💀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a manual step during the release process. I forgot it last time. This will not happen again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should the (unreleased) be removed here or at some point later? I'm still not familiar how our release process works to be honest.

Copy link
Member Author

@daschuer daschuer Jun 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be dine during the manual tagging process.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thank you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was a pre-tag git hook that could check those things and warn if we forgot something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you "upload" tags to the remote using git push <remote> <tagname>, maybe you could filter for tags in the pre-push hook?

Holzhaus
Holzhaus reviewed Jun 7, 2022
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some comments.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated

* Pioneer-DDJ-SB3: fix shift button release [#4659](https://github.com/mixxxdj/mixxx/pull/4659)
* Traktor S3: Push two deck switches to explicitly clone decks [#4665](https://github.com/mixxxdj/mixxx/pull/4665) [#4671](https://github.com/mixxxdj/mixxx/pull/4671) [lp:1960680](https://bugs.launchpad.net/mixxx/+bug/1960680)
* Behringer DDM4000: Update controller mapping [#4318](https://github.com/mixxxdj/mixxx/pull/4318)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think its super important to list that here. People can look at the PR description if they're interested

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we should mention what changed (unless there are too many). As a user i'd want to know if only bugs were fixed or if I need to learn a new mapping. This should be obvious without clicking on the PR and reading the code.

What about "Behringer DDM4000: Fix various bugs and add soft-takeover for encoder knobs"? At least that's what I read from the PR description.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
* Fix rare SEGFAULT when closing the progress dialog [#4695](https://github.com/mixxxdj/mixxx/pull/4695)
* Prevent preferences dialog from going out of screen [#4613](https://github.com/mixxxdj/mixxx/pull/4613)
* Fix undesired jump-cuts in Auto-DJ [#4693](https://github.com/mixxxdj/mixxx/pull/4693) [lp:1948975](https://bugs.launchpad.net/mixxx/+bug/1948975) [lp:1893197](https://bugs.launchpad.net/mixxx/+bug/1893197)
* Fix stopped Auto-DJ [#4698](https://github.com/mixxxdj/mixxx/pull/4698) [lp:1893197](https://bugs.launchpad.net/mixxx/+bug/1893197) [lp:1961970](https://bugs.launchpad.net/mixxx/+bug/1961970)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds wrong. How about "Fix bug that caused Auto DJ to stop playback after some time"

CHANGELOG.md Outdated
* Fix undesired jump-cuts in Auto-DJ [#4693](https://github.com/mixxxdj/mixxx/pull/4693) [lp:1948975](https://bugs.launchpad.net/mixxx/+bug/1948975) [lp:1893197](https://bugs.launchpad.net/mixxx/+bug/1893197)
* Fix stopped Auto-DJ [#4698](https://github.com/mixxxdj/mixxx/pull/4698) [lp:1893197](https://bugs.launchpad.net/mixxx/+bug/1893197) [lp:1961970](https://bugs.launchpad.net/mixxx/+bug/1961970)
* Do not reset xfader when Auto-DJ is deactivated [#4714](https://github.com/mixxxdj/mixxx/pull/4714) [lp:1965298](https://bugs.launchpad.net/bugs/1965298)
* Change the minimum Auto-DJ transition time to -99 [#4768](https://github.com/mixxxdj/mixxx/pull/4768) [lp:1975552](https://bugs.launchpad.net/mixxx/+bug/1975552)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You used "Auto-DJ" but in the manual it's called "Auto DJ" without the dash. We should be consistent IMHO.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Swiftb0y
Swiftb0y reviewed Jun 7, 2022
View reviewed changes
CHANGELOG.md Outdated
@@ -1,5 +1,27 @@
# Changelog

## [2.3.2](https://launchpad.net/mixxx/+milestone/2.3.3) (unreleased)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we remove the (unreleased) here or does that the changelog updater tool for us? I forgor 💀

CHANGELOG.md Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Jun 8, 2022

please add recently merged #4789 + #4791
* Fix passthrough-related crash in waveform code [#4789](https://github.com/mixxxdj/mixxx/pull/4789) [#4791](https://github.com/mixxxdj/mixxx/pull/4791) [lp:1959489](https://bugs.launchpad.net/mixxx/+bug/1959489) [lp:1977662](https://bugs.launchpad.net/mixxx/+bug/1977662)

@daschuer @Holzhaus
@Swiftb0y @ronso0
Update CHANGELOG.md for the 2.3.3 release
8d95356 
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
Co-authored-by: ronso0 <ronso0@mixxx.org>
@daschuer
Copy link
Member Author

daschuer commented Jun 8, 2022

I think all comments are addressed.

@Swiftb0y Swiftb0y merged commit 0554a88 into mixxxdj:2.3 Jun 12, 2022
@daschuer daschuer deleted the changelog_2.3.3 branch October 12, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoergAtGithub JoergAtGithub JoergAtGithub left review comments

@Swiftb0y Swiftb0y Swiftb0y approved these changes

@ronso0 ronso0 ronso0 left review comments

@Holzhaus Holzhaus Holzhaus left review comments

@uklotzde uklotzde uklotzde left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@daschuer @ronso0 @uklotzde @Holzhaus @Swiftb0y @JoergAtGithub