-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of gsl::not_null<T*>() #4782
Conversation
@@ -59,6 +59,7 @@ Build-Depends: debhelper (>= 11), | |||
libudev-dev, | |||
# Note: libdjinterop is available within the Mixxx PPA | |||
libdjinterop-dev, | |||
libmsgsl-dev, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we handle this on other linux distros? fedora doesn't package the gsl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, as "guidelines-support-library" https://repology.org/project/ms-gsl/versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Development-only: guidelines-support-library-devel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I should've looked better.
@Holzhaus how can we add ms-gsl to Arch Linux? |
We need to update the docker container and add this: https://archlinux.org/packages/community/any/microsoft-gsl/ We need to update it anyway for Qt 6.3.0. |
I do not know how to do it. Can you take care? |
https://github.com/Holzhaus/mixxx/tree/bump-archlinux-qt6-to-6.3.0 |
@daschuer please rebase. Thanks. |
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM
Windows and MacOs will fail until we have merged the vcpkg update.