Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of gsl::not_null<T*>() #4782

Merged
merged 3 commits into from
Jun 12, 2022
Merged

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jun 1, 2022

Windows and MacOs will fail until we have merged the vcpkg update.

@github-actions github-actions bot added the build label Jun 1, 2022
@daschuer daschuer marked this pull request as draft June 1, 2022 22:37
@@ -59,6 +59,7 @@ Build-Depends: debhelper (>= 11),
libudev-dev,
# Note: libdjinterop is available within the Mixxx PPA
libdjinterop-dev,
libmsgsl-dev,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we handle this on other linux distros? fedora doesn't package the gsl

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, as "guidelines-support-library" https://repology.org/project/ms-gsl/versions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Development-only: guidelines-support-library-devel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I should've looked better.

src/engine/readaheadmanager.h Outdated Show resolved Hide resolved
@daschuer
Copy link
Member Author

@Holzhaus how can we add ms-gsl to Arch Linux?

@Holzhaus
Copy link
Member

Holzhaus commented Jun 11, 2022

@Holzhaus how can we add ms-gsl to Arch Linux?

We need to update the docker container and add this: https://archlinux.org/packages/community/any/microsoft-gsl/

We need to update it anyway for Qt 6.3.0.

@daschuer
Copy link
Member Author

I do not know how to do it. Can you take care?

@Holzhaus
Copy link
Member

I do not know how to do it. Can you take care?

https://github.com/Holzhaus/mixxx/tree/bump-archlinux-qt6-to-6.3.0

@Swiftb0y
Copy link
Member

@daschuer please rebase. Thanks.

@daschuer daschuer marked this pull request as ready for review June 12, 2022 18:16
@daschuer daschuer requested a review from Swiftb0y June 12, 2022 18:17
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@Swiftb0y Swiftb0y merged commit d5adcf7 into mixxxdj:main Jun 12, 2022
@daschuer daschuer added this to the 2.4.0 milestone Jun 21, 2022
@daschuer daschuer deleted the not_null branch October 12, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants