KeyControl: init keylock from config, fix pitchRatio rounding issue #4756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the two first bugfix commits from #4710, + debug output
Keylock ON not considered after start
https://bugs.launchpad.net/mixxx/+bug/1943180
Internal
m_pitchRateInfo.keylock
is updated only inKeyControl::updateRate()
when any rate, keylock or vc controls are touched. Though, it may be requested by EngineBuffer prior to that, e.g when nudging a track, which results in a temporary keychange.Also, with keylock enabled after start, the first call of
KeyControl::updateRate()
would interpret the update as keylock change which seems to affectm_pitchRateInfo
members unintentionally.Fix: update
m_pitchRateInfo.keylock
when initializingSudden false-positive pitch offset when unlocking key, see #4710 (comment)
probably regression from #1222
Fix: round pitchRatio if it's veeeery close to 1.0