Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyControl: init keylock from config, fix pitchRatio rounding issue #4756

Merged
merged 3 commits into from
May 12, 2022

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented May 12, 2022

the two first bugfix commits from #4710, + debug output

Keylock ON not considered after start
https://bugs.launchpad.net/mixxx/+bug/1943180

Internal m_pitchRateInfo.keylock is updated only in KeyControl::updateRate() when any rate, keylock or vc controls are touched. Though, it may be requested by EngineBuffer prior to that, e.g when nudging a track, which results in a temporary keychange.
Also, with keylock enabled after start, the first call of KeyControl::updateRate() would interpret the update as keylock change which seems to affect m_pitchRateInfo members unintentionally.
Fix: update m_pitchRateInfo.keylock when initializing

Sudden false-positive pitch offset when unlocking key, see #4710 (comment)
probably regression from #1222
Fix: round pitchRatio if it's veeeery close to 1.0

@daschuer
Copy link
Member

There is a clang format issue.

@daschuer daschuer added this to the 2.3.3 milestone May 12, 2022
@ronso0 ronso0 force-pushed the keylock-fix-simple branch from 25c70e6 to 8a7ced3 Compare May 12, 2022 20:38
@daschuer
Copy link
Member

I just did a brief test and it works good. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants