Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Drop workarounds for sccache v0.2.x #4741

Merged
merged 2 commits into from
May 5, 2022
Merged

CI: Drop workarounds for sccache v0.2.x #4741

merged 2 commits into from
May 5, 2022

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented May 5, 2022

...after sccache v0.3.0 has been released.

...after sccache v0.3.0 has been released.
@uklotzde uklotzde added the build label May 5, 2022
@uklotzde
Copy link
Contributor Author

uklotzde commented May 5, 2022

First build on Windows: 47m (before: 38m)

@uklotzde
Copy link
Contributor Author

uklotzde commented May 5, 2022

The new cache key does not depend on any particular version of sccache. Not sure if this is still needed.

@daschuer
Copy link
Member

daschuer commented May 5, 2022

At least the original referenced commit is part of the 0.3.0 release
mozilla/sccache@3f318a8

The 9 minutes penalty is concerning though.
I think we need a windows user to verify the performance before merge.

Should we also pin the version?

@uklotzde
Copy link
Contributor Author

uklotzde commented May 5, 2022

2nd build: 16m

@uklotzde
Copy link
Contributor Author

uklotzde commented May 5, 2022

Should we also pin the version?

Probably. 785eb2f

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK than let's merge this. Thank you for taking care.

@daschuer daschuer merged commit bb2ff2d into mixxxdj:2.3 May 5, 2022
@uklotzde uklotzde deleted the sccache-v0.3.x branch May 23, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants