-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOs warnigs fix #4732
MacOs warnigs fix #4732
Conversation
…9b5ee24cc494 This fixes the deprication warning of OSMemoryBarrier()
4a94f9f
to
61adb81
Compare
@@ -437,7 +437,7 @@ int shout_set_metadata(shout_t *self, shout_metadata_t *metadata) | |||
goto error_socket; | |||
if (upgrade[0] == 0) | |||
break; | |||
if (!strncasecmp(upgrade, "Content-Length: ", 16) == 0) | |||
if (strncasecmp(upgrade, "Content-Length: ", 16) == 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you submit an upstream PR for this fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream has already fixed this. They are on Version 2.4.4, but we are sucked with 2.4.1.
Done. |
9d04a5b
to
447383e
Compare
447383e
to
51d4a97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem reasonable. Thank you! LGTM
This fixes some warnings that are shown when building for MacOS. See commit messages.