Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOs warnigs fix #4732

Merged
merged 10 commits into from
Apr 27, 2022
Merged

MacOs warnigs fix #4732

merged 10 commits into from
Apr 27, 2022

Conversation

daschuer
Copy link
Member

This fixes some warnings that are shown when building for MacOS. See commit messages.

@@ -437,7 +437,7 @@ int shout_set_metadata(shout_t *self, shout_metadata_t *metadata)
goto error_socket;
if (upgrade[0] == 0)
break;
if (!strncasecmp(upgrade, "Content-Length: ", 16) == 0)
if (strncasecmp(upgrade, "Content-Length: ", 16) == 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you submit an upstream PR for this fix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream has already fixed this. They are on Version 2.4.4, but we are sucked with 2.4.1.

src/util/sample.cpp Show resolved Hide resolved
@daschuer
Copy link
Member Author

Done.

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem reasonable. Thank you! LGTM

@uklotzde uklotzde merged commit 3805948 into mixxxdj:2.3 Apr 27, 2022
@daschuer daschuer deleted the clang_var_array branch May 4, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants