BasePlaylistFeature: add popup asking deletion playlist

[fatihemreyildiz]

to avoid accidental deletion due to Remove on playlist.

Forum Thread Link
Launchpad Bug Link

I want to contribute this project via GSOC. In order to get used to project, I saw this bug and tried to fix it.

ScreenShot

[daschuer]

Thank you very much Emre.
In order to ship our patch with Mixxx, we need your permission. Please sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ and comment here when done.

[fatihemreyildiz]

Thank you very much Emre. In order to ship our patch with Mixxx, we need your permission. Please sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ and comment here when done.

Done 👍

[daschuer]

The code looks good to me. You may assign the Launchpad bug to yourselves.

[snoov]

Hi, important feature. Thanks. There should be the same warning when deleting crates. Possibly the same thing when deleting a track (accidentally), but the consequences are still less important.

[uklotzde]

I disagree, at least for individual tracks. Even for crates and playlists this feature is questionable. We already discussed that adding confirmation dialogs everywhere affects usability. Instead proper undo/redo is needed.

[haliliceylan]

I disagree, at least for individual tracks. Even for crates and playlists this feature is questionable. We already discussed that adding confirmation dialogs everywhere affects usability. Instead proper undo/redo is needed.

maybe a checkbox like "don't show it again" or "don't ask again" can solve everything, I think the question boxes we are all used to are useful.

[Be-ing]

That is not the same thing and IMO does not really help the usability. This dialog is fine as a quick hack, but it's not really an ideal solution.

[snoov]

Sorry, but confirmation boxes for delete operations are still quite commonly used. A priori, they only appear when you want to delete. In this case it may "affects usability", but personally I prefer something that "affects usability", rather than losing a playlist or a crate of 200 tracks that took hours of work ! Especially since it is still very easy to click on delete when you just wanted to rename a box! Besides, " in the action ", an accidental right-click and ending up clicking delete can happen easily. It happened to me on a track and I didn't notice it right away. So in this case an undo wouldn't have helped me much.