Qmllint fixes #4680
Merged
Qmllint fixes #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
must be a QML lint bug. |
Yes, that just makes qmllint happy. So there are two bugs with qmllint? Are you able to describe this issue as an upstream bug? |
|
So we can merge this for now? |
Holzhaus
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes on remaining qmllint issue.
It can be fixed for qmllint by
parent.parent.parent.groupBut than it no longer works in the code.
I guess it is a qmllint bug, but I have not enough experience to report it upstream.
The other issue was introduced by:
#4673