Fixed possible segfault on contol behaviour change. This is a mid-term s... #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m solution until we have collected all needs by the effect branch and are able to optimize this out.
| m_defaultValue.setValue(0); | ||
| m_value.setValue(0); | ||
|
|
||
| m_sqCOHashMutex.lock(); |
There was a problem hiding this comment.
These 3 lines are unrelated to this change, right?
There was a problem hiding this comment.
Yes, they are also part of my other pending pull request #41. So I will remove them here.
|
LGTM other than the 3 stray lines. Thanks! |
|
Thank you for review @rryan |
daschuer
added a commit
that referenced
this pull request
Jul 13, 2013
Fixed possible segfault on contol behaviour change.
Merged
11 tasks
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
Replace social media widgets with social media links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...olution until we have collected all needs by the effect branch and are able to optimize this out.
I have done this solution, because it is the simplest way to fix this issue without finish our strategy discussion.
So we have a clean solution and we can optimize this for speed later, if required.