Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlobjectscripttest cleanup #4599

Merged

Conversation

JoergAtGithub
Copy link
Member

@JoergAtGithub JoergAtGithub commented Jan 3, 2022

This PR contains two code cleanups:

  • Removed unnecessary include statement
  • Removed contradictory .WillOnce(Return()) conditions where the cardinality is specified as .Times(0)
    This generated a warning, which was only visible in verbose mode

And one fix:

  • This fixes the fail of all tests in controlobjectscripttest.cpp on the local Linux from @ronso0 (see merge 2.3 #4588 for details).
    The fix is copied from controllerscriptenginelegacy_test.cpp where a similar issue occurred. But the comment is adapted, to what was seen with controlobjectscripttest.cpp.

…ality is specified as .Times(0)

This generated a warning, which was only visible in verbose mode
…local Linux build.

The fix is copied from controllerscriptenginelegacy_test.cpp where a similar issue occurred. But the comment is adapted, to what was seen with controlobjectscripttest.cpp.
@JoergAtGithub JoergAtGithub force-pushed the controlobjectscripttest_cleanup branch from 69e34ce to 8771d01 Compare January 3, 2022 21:11
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Holzhaus Holzhaus added this to the 2.4.0 milestone Jan 3, 2022
@Holzhaus Holzhaus merged commit 343b1a1 into mixxxdj:main Jan 3, 2022
@ronso0
Copy link
Member

ronso0 commented Jan 3, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants