Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up: SoundSourceProxy cleanup #4598

Merged
merged 2 commits into from
Jan 2, 2022
Merged

Follow-up: SoundSourceProxy cleanup #4598

merged 2 commits into from
Jan 2, 2022

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Jan 2, 2022

Another minor refactoring, the commit messages reveal the intention.

@uklotzde uklotzde requested a review from daschuer January 2, 2022 08:46
Holzhaus
Holzhaus approved these changes Jan 2, 2022
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, waiting for CI. Thank you.

daschuer
daschuer approved these changes Jan 2, 2022
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit 6e3295f into mixxxdj:main Jan 2, 2022
@uklotzde uklotzde deleted the soundsourceproxy branch January 5, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @daschuer @Holzhaus