Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose sleep() workarounds for QT4 #4589

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Dispose sleep() workarounds for QT4 #4589

merged 1 commit into from
Dec 29, 2021

Conversation

daschuer
Copy link
Member

QThread::sleep() is no longer protected in Qt5

@github-actions github-actions bot added the build label Dec 28, 2021
Holzhaus
Holzhaus approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, waiting for CI. Thank you.

@uklotzde uklotzde merged commit 1daa7c6 into mixxxdj:main Dec 29, 2021
@daschuer daschuer deleted the sleep branch April 14, 2022 21:19
@ronso0 ronso0 mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daschuer @Holzhaus @uklotzde