WSpinny: allow to toggle cover art at runtime #4565
Conversation
8aabd61 to
46822b3
Compare
| @@ -176,7 +178,19 @@ void WSpinny::setup(const QDomNode& node, const SkinContext& context) { | |||
| size(), Qt::KeepAspectRatio, Qt::SmoothTransformation); | |||
| } | |||
|
|
|||
| m_bShowCover = context.selectBool(node, "ShowCover", false); | |||
| // Dynamic skin option, set in WSpinny's <ShowCoverControl> node. | |||
| if (showCoverConfigKey.isValid()) { | |||
There was a problem hiding this comment.
Does the config key for showing cover art have to be configurable? Why can't it just be a single CO defined inside Mixxx? (e.g, always [Skin],show_coverart). Its value never varies in the updates you made
There was a problem hiding this comment.
I'd like this to be configurable because spinny and cover art can also be shown separately, like in Deere (which I'll adjust in a separate PR) (**Edit:**no need for adjustments there): spinnies next to the waveforms always show the cover while the cover can be toggled in the decks.
|
LateNight works like a charm. In Tango there is a grayed out element which is grayed out even more if the spinny and the cover-art is disabled: At least it is no regression form main. Is this related here? |
|
yeah the Tango settings UX there is not optimal. anyway, the skins should look exactly as before. |
|
OK so we can merge. Thank you. |
https://bugs.launchpad.net/mixxx/+bug/1883362
This allows to have only one spinny instance per deck, which in return allows to simplify the skins (and probably decreases memory footprint a bit).