Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isDirty() signature and semantics #4534

Merged
merged 2 commits into from
Nov 21, 2021
Merged

Fix isDirty() signature and semantics #4534

merged 2 commits into from
Nov 21, 2021

Conversation

uklotzde
Copy link
Contributor

Minor code quality refactoring:

  • Add missing const qualifiers to isDirty()
  • TrackDAO: Fix semantics of marking a track clean after update

@uklotzde uklotzde mentioned this pull request Nov 20, 2021
Draft
@uklotzde
Copy link
Contributor Author

Anyone willing to hit merge? This change is almost trivial, except the move of markClean() to the correct spot.

@Holzhaus Holzhaus merged commit b3bf167 into mixxxdj:main Nov 21, 2021
@uklotzde uklotzde deleted the is-dirty-const branch November 22, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
code quality library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @Holzhaus