Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roland DJ-505: Use let/const instead of var #4517

Merged
merged 2 commits into from
Nov 13, 2021
Merged

Roland DJ-505: Use let/const instead of var #4517

merged 2 commits into from
Nov 13, 2021

Conversation

Holzhaus
Copy link
Member

No description provided.

@Holzhaus Holzhaus added this to the 2.4.0 milestone Nov 13, 2021
Swiftb0y
Swiftb0y requested changes Nov 13, 2021
View reviewed changes
res/controllers/Roland_DJ-505-scripts.js Show resolved Hide resolved
res/controllers/Roland_DJ-505-scripts.js Outdated Show resolved Hide resolved
@Holzhaus @Swiftb0y
Update res/controllers/Roland_DJ-505-scripts.js
9b39907 
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
Swiftb0y
Swiftb0y approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@Swiftb0y Swiftb0y merged commit dea9f71 into mixxxdj:main Nov 13, 2021
@N07070 N07070 mentioned this pull request Apr 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
controller mappings
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Holzhaus @Swiftb0y