Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects refactoring minor fixes #4462

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

daschuer
Copy link
Member

No description provided.

@Be-ing
Copy link
Contributor

Be-ing commented Oct 20, 2021

Build failed:

 In file included from /home/runner/work/mixxx/mixxx/src/effects/backends/builtin/autopaneffect.cpp:1:
/home/runner/work/mixxx/mixxx/src/effects/backends/builtin/autopaneffect.h: In constructor ‘RampedSample::RampedSample()’:
Error: /home/runner/work/mixxx/mixxx/src/effects/backends/builtin/autopaneffect.h:24:32: error: expression list treated as compound expression in mem-initializer [-fpermissive]
   24 |               initialized(false) {
      |                                ^
Error: /home/runner/work/mixxx/mixxx/src/effects/backends/builtin/autopaneffect.h:23:28: error: left operand of comma operator has no effect [-Werror=unused-value]
   23 |               currentValue(0, 0),
      |                            ^

@daschuer daschuer force-pushed the effects_refactoring_1 branch from 649d7d5 to afc940c Compare October 20, 2021 22:01
@Be-ing Be-ing merged commit b96d24b into mixxxdj:effects_refactoring Oct 21, 2021
@daschuer daschuer deleted the effects_refactoring_1 branch April 14, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants