Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: update Clear button when search is disabled #4447

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 16, 2021

minor issue I noticed while styling search history in main:
when switching from a feature with search enabled to let's say AutoDJ, the Clear button would remain even though it's pointless.

@github-actions github-actions bot added the ui label Oct 16, 2021
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@uklotzde uklotzde merged commit b6b37ac into mixxxdj:2.3 Oct 17, 2021
@ronso0 ronso0 deleted the search-update-clear-button branch October 17, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants