Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlayerManager: replace QString::midRef with QRegularExpressions #4419

Merged
merged 1 commit into from
Oct 14, 2021
Merged

PlayerManager: replace QString::midRef with QRegularExpressions #4419

merged 1 commit into from
Oct 14, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 14, 2021

QString::midRef has been removed in Qt6.

uklotzde
uklotzde suggested changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments apply to all occurrences

src/mixer/playermanager.cpp Outdated Show resolved Hide resolved
src/mixer/playermanager.cpp Outdated Show resolved Hide resolved
@uklotzde
Copy link
Contributor

Good decision to use this opportunity for replacing the manual parsing with regexes!

@Be-ing Be-ing force-pushed the playermanager_regexes branch 3 times, most recently from 8dc7f76 to 7e5b5a1 Compare October 14, 2021 10:04
uklotzde
uklotzde suggested changes Oct 14, 2021
View reviewed changes
src/mixer/playermanager.cpp Outdated Show resolved Hide resolved
@Be-ing Be-ing force-pushed the playermanager_regexes branch from 7e5b5a1 to 543fc4a Compare October 14, 2021 13:22
uklotzde
uklotzde approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@uklotzde uklotzde merged commit e3570b1 into mixxxdj:main Oct 14, 2021
@Be-ing Be-ing deleted the playermanager_regexes branch October 14, 2021 21:15
@daschuer daschuer mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Qt6
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @uklotzde