Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: link to Xlib with Qt6 #4416

Merged
merged 1 commit into from
Oct 14, 2021
Merged

CMake: link to Xlib with Qt6 #4416

merged 1 commit into from
Oct 14, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 13, 2021

This is required for src/util/screensaver.cpp.

@Holzhaus
Copy link
Member

Maybe we can get rid of this ugly hack by usi g this? https://doc-snapshots.qt.io/qt-mobility/qml-screensaver.html

Anyway, probably out of scope for this PR.

@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 13, 2021

I think more work will be needed to make screensaver.cpp detect the QPA plugin used at runtime and implement a way to inhibit the screensaver with Wayland. That is beyond the scope of this PR though.

@github-actions github-actions bot added the build label Oct 13, 2021
CMakeLists.txt Outdated Show resolved Hide resolved
@Be-ing Be-ing force-pushed the qt6_link_x branch 2 times, most recently from 65014b8 to 0c5df03 Compare October 14, 2021 09:43
This is required for src/util/screensaver.cpp.
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@uklotzde uklotzde merged commit f8dba81 into mixxxdj:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants