explicitly convert QStrings to QFileInfos #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor for converting a QString to a QFileInfo was made explicit in Qt6.
uklotzde
approved these changes
Oct 13, 2021
| } | ||
|
|
||
| TEST_F(SoundSourceProxyTest, getTypeFromMissingFile) { | ||
| // Also verify that the shortened suffix ".aif" (case-insensitive) is | ||
| // mapped to file type "aiff", independent of whether the file exists or not! | ||
| const QFileInfo missingFileWithUppercaseSuffixAndLeadingTrailingWhitespaceSuffix = | ||
| kTestDir.absoluteFilePath(QStringLiteral("missing_file. AIF ")); | ||
| const QFileInfo missingFileWithUppercaseSuffixAndLeadingTrailingWhitespaceSuffix( |
There was a problem hiding this comment.
This might be easier to read and resembles the let syntax as found in Rust:
const auto varName = VarType(..constructor args...);
Just a personal opinion and hint, no need to change anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor for converting a QString to a QFileInfo was made
explicit in Qt6.