Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: do not build legacy LibraryFeatures with Qt6 #4393

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 13, 2021

Getting these building with Qt6 would require nontrivial effort
and probably be a waste of time anyway.
https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/QML.20library.20GUI/near/257231756

@github-actions github-actions bot added the build label Oct 13, 2021
@uklotzde
Copy link
Contributor

Please rebase

Getting these building with Qt6 would require nontrivial effort
and probably be a waste of time anyway.
https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/QML.20library.20GUI/near/257231756
@Be-ing Be-ing force-pushed the legacy_libraryfeatures branch from 94ad946 to 0a367c7 Compare October 13, 2021 12:41
@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 13, 2021

rebased

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 305e741 into mixxxdj:main Oct 13, 2021
@Be-ing Be-ing deleted the legacy_libraryfeatures branch October 13, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants