Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History feature: fix right-click index #4384

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 12, 2021

before an invalid playlist ID was used to update the context menu actions. For example a locked playlist would still have an "Lock" action, even though the correct action would be triggered, or refused.

@ronso0 ronso0 force-pushed the history-right-click-index branch from fa4edba to cc34ceb Compare October 12, 2021 15:24
@ronso0 ronso0 modified the milestones: 2.3.2, 2.4.0 Oct 12, 2021
@uklotzde uklotzde changed the base branch from main to 2.3 October 12, 2021 17:01
@uklotzde uklotzde changed the base branch from 2.3 to main October 12, 2021 17:01
@uklotzde
Copy link
Contributor

Does this also affect 2.3? I think so. Then please rebase.

@ronso0
Copy link
Member Author

ronso0 commented Oct 12, 2021

Nope, 2.3 works fine, the actions are labeled and enabled correctly.

@uklotzde
Copy link
Contributor

Nope, 2.3 works fine, the actions are labeled and enabled correctly.

...because 2.3 uses the same code that you just changed.

@ronso0
Copy link
Member Author

ronso0 commented Oct 12, 2021

I know, because of that first based the fix onto 2.3
The 2.3 Playlists feature uses int playlistId = playlistIdFromIndex(index);, too.
So I think this was a leftover and something was screwed up during or after the History feature overhaul (new root view, reversed list order). Don't know, don't care tbh. Works now.

@uklotzde
Copy link
Contributor

Ok, got it. Maybe I checked out the wrong branch.

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@uklotzde uklotzde merged commit a7bbbd3 into mixxxdj:main Oct 12, 2021
@ronso0 ronso0 deleted the history-right-click-index branch October 12, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants