Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass focus to library after effect, beat size or Auto DJ transition configuration #4360

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 6, 2021

Automatically re-enable keyboard shortcuts by passing focus to the tracks table (official skins) after

  • picking an effect
  • pressing Enter in a beat size spinbox
  • pressing Enter in the Auto DJ transition time spinbox
  • picking an Auto DJ transition mode

with an emulated Shift+Tab keypress.

This primarily fixes fixes rare bug lp:1902125 effect selector can't be opened on Arch (cause by `setFocusPolicy(Qt::NoFocus);

And lp:1943325 remove focus from lineedits after pressing Enter to allow keyboard shortcuts

@ronso0 ronso0 marked this pull request as ready for review October 7, 2021 13:55
@ronso0
Copy link
Member Author

ronso0 commented Oct 7, 2021

Ready for review

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and works nice. Thank you.

@daschuer daschuer merged commit 7618abf into mixxxdj:main Oct 7, 2021
@ronso0 ronso0 deleted the lineedit-focus branch October 7, 2021 18:08
@ronso0
Copy link
Member Author

ronso0 commented Oct 9, 2021

after reading the searchbox tooltip I noticed that Esc would always focus the library¹ no matter if any / which widget is focused.
This should be in the keyboard docu.

¹ if the current library view is a WTrackTableView instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants