Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundSource: Fix file type detection #4357

Merged
merged 5 commits into from
Oct 5, 2021
Merged

SoundSource: Fix file type detection #4357

merged 5 commits into from
Oct 5, 2021

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Oct 5, 2021

Follow-up of #4356, including a changelog entry.

Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails on CI (Ubuntu).

src/sources/soundsource.cpp Outdated Show resolved Hide resolved
@uklotzde
Copy link
Contributor Author

uklotzde commented Oct 5, 2021

Oh, no. Why does Qt 5.12 on Ubuntu 18.04 behave differently for missing files 😠 Qt is such a bastard if you need to support different versions.

@Holzhaus Holzhaus merged commit f2ec8a2 into mixxxdj:2.3 Oct 5, 2021
@uklotzde uklotzde deleted the soundsource-mimetype branch October 5, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants