add [Library],clear_search #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
requested changes
Sep 30, 2021
276e172 to
4b0e266
Compare
daschuer
reviewed
Sep 30, 2021
daschuer
reviewed
Sep 30, 2021
Co-authored-by: daschuer <daschuer@mixxx.org>
4b0e266 to
b8fd584
Compare
|
waiting for CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(noticed when adding the controls documentation to the manual)
add
[Library],clear_searchto complete the searchbox controls set.the search can also be cleared by scrolling to the top, but that easily overshots and wraps around.
Also a direct control is simpler than scroling through a list (for the same reason I argue the Clear button should be focusable by
MoveFocus)