Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit hooks #4314

Merged
merged 3 commits into from
Sep 20, 2021
Merged

Update pre-commit hooks #4314

merged 3 commits into from
Sep 20, 2021

Conversation

uklotzde
Copy link
Contributor

Two minor updates and a manual edit to prevent reformatting due to a false positive.

How to test

Run the following command:

SKIP=clang-format,eslint,end-of-file-fixer,trailing-whitespace \
pre-commit run --all-files

Expected result: No changes

daschuer
daschuer approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit d462df5 into mixxxdj:2.3 Sep 20, 2021
@uklotzde uklotzde deleted the pre-commit branch September 23, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality controller mappings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @daschuer