Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract utility functions for QUuid #4308

Merged
merged 4 commits into from
Sep 19, 2021
Merged

Extract utility functions for QUuid #4308

merged 4 commits into from
Sep 19, 2021

Conversation

uklotzde
Copy link
Contributor

Move QUuid utility functions from util/compatibility.h into util/quuid.h.

Be-ing
Be-ing suggested changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working on a PR to remove these obsolete compatibility functions.

@github-actions github-actions bot added the ui label Sep 19, 2021
@Be-ing
Copy link
Contributor

Be-ing commented Sep 19, 2021

#4309

@uklotzde uklotzde mentioned this pull request Sep 19, 2021
Merged
@uklotzde
Copy link
Contributor Author

uklotzde commented Sep 19, 2021 •
edited
Loading

I have removed the obsolete utility function and the corresponding tests. Didn't notice that before.

Be-ing
Be-ing approved these changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI

@Be-ing Be-ing merged commit dfa61fa into mixxxdj:main Sep 19, 2021
@uklotzde uklotzde deleted the quuid branch September 19, 2021 18:30
@daschuer daschuer mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing approved these changes

Assignees
No one assigned
Labels
build code quality library ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @Be-ing