AppStream metainfo fixes

[Be-ing]

No description provided.

[uklotzde]

This change might break existing packaging recipes and requires a note for maintainers.

[Be-ing]

I'll add a note to packagers in the CHANGELOG after both this and #4204 are merged.

[uklotzde]

Merging the generated org.mixxx.Mixxx.metainfo.xml might become difficult. Changes in the release history need to be ignored and re-generated in the target branch. Did you consider this?

[Holzhaus]

I think it should be straightforward:

1. Merge conflict in the metainfo.xml file
2. Instead of running git mergetool, just add the metainfo file including the conflict markers to the staging area
3. Now run pre-commit run metainfo (all changes are staged)
4. The hook regenerates the metainfo.xml
5. git add the changes and commit

[uklotzde]

How about adding a comment before the <releases> start tag that explains that the contents are generated by pre-commit run metainfo? This is not obvious and not documented.

[Be-ing]

How about adding a comment before the start tag that explains that the contents are generated by pre-commit run metainfo? This is not obvious and not documented.

Good idea, done.

[Be-ing]

Something weird is going on with the new pre-commit hook. It passed when I made the last commit, but now GitHub Actions is not passing. I downloaded and applied the patch from GitHub Actions, then tried to commit but when the hook ran again locally it canceled out the patch??

[Holzhaus]

Did you rebase or something. The changes look legit, not some miniscule formatting issues. So I suppose there is a difference in the changelog versions.

[uklotzde]

Locally the metainfo hook for this branch passes. We cannot merge before the GitHub issues are fixed.

[Be-ing]

I removed the commit with the manual changes and reran the script. Now pre-commit passes.

[Be-ing]

Please don't let this linger any longer. I am tired of having to rebase and rerun the script.

[Swiftb0y]

I struggle to understand the [^\)]+ part.

[Holzhaus]

I recommend regex101.com:

It's supposed to match any char except ) one or more times (for the milestone URL):

[uklotzde]

Ok for me.

[Be-ing]

Merge?