Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install multiple sizes of rasterized icons #4204

Merged
merged 1 commit into from
Aug 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1349,16 +1349,12 @@ if(UNIX AND NOT APPLE)

# Icon files for menu entry
install(
FILES
"${CMAKE_CURRENT_SOURCE_DIR}/res/images/icons/mixxx.svg"
DESTINATION
"${CMAKE_INSTALL_DATADIR}/icons/hicolor/scalable/apps"
)
install(
FILES
"${CMAKE_CURRENT_SOURCE_DIR}/res/images/icons/mixxx.png"
DIRECTORY
"${CMAKE_CURRENT_SOURCE_DIR}/res/images/icons"
DESTINATION
"${CMAKE_INSTALL_DATADIR}/icons/hicolor/32x32/apps"
"${CMAKE_INSTALL_DATADIR}/icons/hicolor"
# This file is for Windows.
PATTERN ic_mixxx.ico EXCLUDE
)

# .metainfo.xml file for KDE/GNOME AppStream initiative
Expand Down
Binary file added res/images/icons/128x128/apps/mixxx.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added res/images/icons/256x256/apps/mixxx.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added res/images/icons/32x32/apps/mixxx.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added res/images/icons/512x512/apps/mixxx.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added res/images/icons/64x64/apps/mixxx.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed res/images/icons/mixxx.png
Binary file not shown.
File renamed without changes
2 changes: 1 addition & 1 deletion res/mixxx.qrc
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<file>images/library/ic_library_serato.svg</file>
<!-- logo and icons for 'About' dialog -->
<file>images/mixxx_logo.svg</file>
<file>images/icons/mixxx.svg</file>
<file>images/icons/scalable/apps/mixxx.svg</file>
<file>images/heart_icon_light.svg</file>
<file>images/heart_icon_dark.svg</file>
<file>images/heart_icon_rainbow.svg</file>
Expand Down
2 changes: 1 addition & 1 deletion src/dialog/dlgabout.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
DlgAbout::DlgAbout(QWidget* parent) : QDialog(parent), Ui::DlgAboutDlg() {
setupUi(this);

mixxx_icon->load(QString(":/images/icons/mixxx.svg"));
mixxx_icon->load(QString(":/images/icons/scalable/apps/mixxx.svg"));
mixxx_logo->load(QString(":/images/mixxx_logo.svg"));

version_label->setText(VersionStore::applicationName() +
Expand Down
2 changes: 1 addition & 1 deletion src/library/scanner/libraryscannerdlg.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
LibraryScannerDlg::LibraryScannerDlg(QWidget* parent, Qt::WindowFlags f)
: QWidget(parent, f),
m_bCancelled(false) {
setWindowIcon(QIcon(":/images/icons/mixxx.svg"));
setWindowIcon(QIcon(":/images/icons/scalable/apps/mixxx.svg"));

QVBoxLayout* pLayout = new QVBoxLayout(this);

Expand Down
2 changes: 1 addition & 1 deletion src/preferences/upgrade.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ UserSettingsPointer Upgrade::versionUpgrade(const QString& settingsPath) {

bool Upgrade::askReScanLibrary() {
QMessageBox msgBox;
msgBox.setIconPixmap(QPixmap(":/images/icons/mixxx.svg"));
msgBox.setIconPixmap(QPixmap(":/images/icons/scalable/apps/mixxx.svg"));
msgBox.setWindowTitle(QMessageBox::tr("Upgrading Mixxx"));
msgBox.setText(QMessageBox::tr("Mixxx now supports displaying cover art.\n"
"Do you want to scan your library for cover files now?"));
Expand Down