Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: remove Protobuf_USE_STATIC_LIBS #4187

Merged
merged 1 commit into from
Aug 9, 2021
Merged

CMake: remove Protobuf_USE_STATIC_LIBS #4187

merged 1 commit into from
Aug 9, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Aug 6, 2021

This does not do anything after find_package(Protobuf)
https://cmake.org/cmake/help/latest/module/FindProtobuf.html

Follow up to #4185

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1106611567

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 26.012%
Totals Coverage Status
Change from base Build 1106567736: 0.001%
Covered Lines: 20019
Relevant Lines: 76962
💛 - Coveralls

daschuer
daschuer approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 9, 2021

merge?

@daschuer
Copy link
Member

daschuer commented Aug 9, 2021

Yes, thank you.

@daschuer daschuer merged commit 759120a into mixxxdj:main Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Be-ing @coveralls @daschuer