Preferences: Remove all references to MixxxMainWindow #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't have any references to the `MixxxMainWindow` class in `DlgPrefInterface` if we want to use the preferences for QML skins that don't have a `MixxxMainWindow` instance. The using the primary screen is a sensible fallback.
Instead of letting the `DlgPrefInterface` class hold a reference to the `MixxxMainWindow` and call its `setToolTipsCfg` method directly, we just update the config object and emit a signal that the main window can connect to.
Instead of calling `rebootMixxxView` directly, we can just emit a signal. This allows removing any references to the `MixxxMainWindow` in `DlgPreferences`.
This is similar to the previous commit, it basically removes the necessity to hold a pointer to the main window.
Pull Request Test Coverage Report for Build 1037258891
💛 - Coveralls |
uklotzde
approved these changes
Jul 18, 2021
|
I didn't experience any issues so far. Thank you! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary if we want to use the preferences in QML without creating a QWidgets-based
MixxxMainWindowinstance.