Track: Fix debug assertion for missing/invalid bpm

[uklotzde]

Occurred after applying changes in DlgTrackInfo.

[coveralls]

Pull Request Test Coverage Report for Build 1023011203

• 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
• 9 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.01%) to 28.629%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/track/track.cpp	3	5	60.0%

Files with Coverage Reduction	New Missed Lines	%
src/engine/cachingreader/cachingreader.cpp	9	71.38%

Totals
Change from base Build 1022999157:	-0.01%
Covered Lines:	20089
Relevant Lines:	70169

---

💛 - Coveralls

[ywwg]

Any way to add a test for this? otherwise lgtm

[uklotzde]

You cannot test a debug assertion.

The invocation of Bpm::value() was wrong. Now it is gone. Nothing to test.

[Holzhaus]

LGTM, thank you. As discussed on Zulip I won't hit merge until @ywwg had the chance to re-review (as he used "Request Changes" instead of "Comment").

[uklotzde]

@ywwg Ping. We already discussed the liabilities that come with Request changes.

[Holzhaus]

@ywwg Ping.

[Holzhaus]

@ywwg ping again. It would nice to get this fix into main soon.

[uklotzde]

There is no point in discussing review practices and contribution guidelines if even the basic rules of communication are not obeyed by ourselves. As a first-time contributor I would have closed the PR left now.

[ywwg]

@ywwg Ping.

I have no idea why github didn't tell me about these pings :(. I am constantly trying to fix my notifications so I only get told about things that are important, but I am buried with notifications about every single PR that happens. Sorry for the delay.

[Swiftb0y]

fyi you can restrict for what activities you get notifications for and you can also filter by the reason you got notified for.

Also please double check some of the recent PRs, there are a bunch that require your attention and you seem to have missed them so far.