-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: use CXX_COMPILER_LAUNCHER instead of RULE_LAUNCH_COMPILE #4098
Conversation
Pull Request Test Coverage Report for Build 1020536608
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, it still works here on Ubuntu. Judged from the Windows build time running since 43 min by now it does not work for windows.
Can a windows contributor confirm that?
The long build time was because there was no cache for the branch yet. |
I just asked upstream for a new release so we can install from Chocolatey instead of taking 10 minutes to build sccache from source. |
4341e01
to
1df8d2b
Compare
This allows for removing the hack for RULE_LAUNCH_COMPILE with sccache. https://gitlab.kitware.com/cmake/cmake/-/issues/22405
1df8d2b
to
855cdc0
Compare
I am confused why GitHub Actions keeps having cache misses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge and keep an eye on Windows build times to detect possible regressions?
The new version is recommended and cleaner.
Yes, I have just compared with other PRs and it is always around 50 min. This is suspicious, but no regression. |
This allows for removing the hack for RULE_LAUNCH_COMPILE with
sccache.
https://gitlab.kitware.com/cmake/cmake/-/issues/22405