-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad phase seek when starting from preroll. #4093
Conversation
This is a great example of where using magic numbers to mean invalid is bad! |
We were interpreting all <0 playposition as "invalid", which is not correct. fixes https://bugs.launchpad.net/mixxx/+bug/1930143
fwiw I don't think this is minor, this caused some trainwrecks in a set I played because the cue points were just barely before the start of the track. |
@ywwg can you take care of the merge to |
yeah sure. I actually wrote it for that and then backported |
Works fine on my machine. Waiting for CI. |
what's the right way to merge to main? do a "git merge 2.3", or do a cherrypick of the commit? |
|
pushed to main |
We were interpreting all <0 playposition as "invalid", which is not correct.
fixes https://bugs.launchpad.net/mixxx/+bug/1930143